Skip to content

fix: Console errors from premature colorbox resize calls#11543

Merged
jimchamp merged 1 commit intointernetarchive:masterfrom
lokesh:fix/undefined-resize
Dec 5, 2025
Merged

fix: Console errors from premature colorbox resize calls#11543
jimchamp merged 1 commit intointernetarchive:masterfrom
lokesh:fix/undefined-resize

Conversation

@lokesh
Copy link
Collaborator

@lokesh lokesh commented Dec 3, 2025

Fixes JS error that appears on books and works pages.
To see the issue live on prod, visit a book page and open the browser dev console to view.

image

Technical

  • Adds checks to make sure colorbox has been attached to the jQuery object before calling the resize.

Stakeholders

@jimchamp @mekarpeles

@jimchamp jimchamp self-assigned this Dec 5, 2025
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lokesh! This is working as expected.

@jimchamp jimchamp merged commit e072b07 into internetarchive:master Dec 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants